bump mypy to run locally, move tools/factories into tests folder
#2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
move-factories-to-tests
branch
6 times, most recently
from
ddf2cf2 to
d371a13
Compare
pacrob
commented
Feb 12, 2025
| TransactionBuilderAPI, | ||
| WithdrawalAPI, | ||
| ) | ||
|
|
||
|
|
||
| class BaseBlock(Configurable, rlp.Serializable, BlockAPI): | ||
| transaction_builder: Type[TransactionBuilderAPI] = None | ||
|
|
There was a problem hiding this comment.
This was added to clarify that it is the rlp.Serializable's __init__ that we want, not BlockAPI's. At runtime, the correct one was being chosen by default, but mypy was confused. And I think it's better to be explicit about it.
pacrob
force-pushed
the
move-factories-to-tests
branch
from
d371a13 to
77a8d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
mypywas still running without locally installed deps.factory-boyis only used in testing, but tools using it were within a public folder.How was it fixed?
Run
mypylocally - decided to do this here, as opposed to with the template update, to keep related change more clearly separated.Moved
eth/tools/factoriestotests/tools/factories.Todo:
Cute Animal Picture