-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ewasm support #923
base: main
Are you sure you want to change the base?
Add ewasm support #923
Conversation
Tie together the software packages (py-evm, juno, pywasm) and test detecting WASM code and passing data and receiving data. One stEWASMtests test (`useGas`) is passing so data is flowing in both directions.
@@ -12,6 +12,7 @@ | |||
"eth-bloom>=1.0.0,<2.0.0", | |||
"eth-utils>=1.0.1,<2.0.0", | |||
"eth-typing>=1.0.0,<2.0.0", | |||
"juno>=0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, https://pypi.org/project/juno/ seems to be something different, no? Where is that dependency coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok I see it is here: https://github.com/lrettig/juno But then, how does that fit in with that juno
package on pypi that seems to be occupied by something else, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't. Two different things, no connection. The name can be changed :) I'm just running this locally, no pypi.
This seems like a good place to dump some brief thoughts.
|
Completely agree. I wouldn't even call this hacky thing a "model." Agree this is important to maintain if possible. |
Dear @pipermerriam , Thank you for your message. My responses follow.
I wish you only the best success. Sincerely, |
Tie together the software packages (py-evm, juno, pywasm) and test
detecting WASM code and passing data and receiving data. One
stEWASMtests test (
useGas
) is passing so data is flowing in bothdirections.
For now the nastiness lives mostly in another package called Juno (which is the Latin name of Hera, which is the EVMC "glue code" in C++). One of the things @poemm and I have been discussing is whether this "glue" code belongs in py-evm or not.
@poemm's pywebassembly lives at https://github.com/poemm/pywebassembly.
Cute Animal Picture