UDapp account dropdown refactor #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LianaHus
reviewed
Nov 20, 2024
| )) : <Dropdown.Item></Dropdown.Item>} | ||
| </Dropdown.Menu> | ||
| </Dropdown> | ||
| {/* <select |
|
could you also check why dropdown-<selected item is blue in Solidity plugin/Compiler configuration |
joeizang
force-pushed
the
account-dropdown-refactor
branch
3 times, most recently
from
96b7472 to
110491c
Compare
joeizang
force-pushed
the
account-dropdown-refactor
branch
from
af6415e to
af6e953
Compare
Those dropdowns are native select elements. We could convert those also but maybe in another pr |
LianaHus
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5400