Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendation for cached-property #46

Merged
merged 2 commits into from
May 14, 2019

Conversation

pipermerriam
Copy link
Member

Add cached-property recommendation

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd support adding this here... already there a few places i can think to use it


### [`cached-property`](https://pypi.org/project/cached-property/)

@piper
Copy link
Member

@ralexstokes ralexstokes May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this is here

edit: i see, its tagged by suggester

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figure it's good to know who was championing something. In theory git blame works for this but that's bad UX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piper suggests:
or
@piper recommends:
to avoid future questions of the same type :)

Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth noting that it collides with __slots__, so you have to choose one or the other.


### [`cached-property`](https://pypi.org/project/cached-property/)

@piper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piper suggests:
or
@piper recommends:
to avoid future questions of the same type :)

@pipermerriam
Copy link
Member Author

FYI about cached_property and slots: pydanny/cached-property#69

Looks like there's a work-around...

@pipermerriam pipermerriam merged commit f14936b into master May 14, 2019
@pipermerriam pipermerriam deleted the piper/cache-property-recommendation branch May 14, 2019 19:23
@carver
Copy link
Contributor

carver commented May 14, 2019

FYI about cached_property and slots: pydanny/cached-property#69

Looks like there's a work-around...

Uh oh, I foresee us forking and maintaining cached_property in the future, looking at that maintenance history...

But yay that there's a solution! pydanny/cached-property#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants