Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translating linkReferences #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix translating linkReferences #242

wants to merge 1 commit into from

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Jul 26, 2018

No description provided.

@axic
Copy link
Member

axic commented Dec 3, 2018

@yann300 what was this change for?

@yann300
Copy link
Contributor Author

yann300 commented Dec 3, 2018

for making sure linkReference for old compilers are mapping of mapping instead of array (i guess to be compliant to standard JSON I/O)
https://github.com/ethereum/solc-js/pull/242/files#diff-dd1cfac53126f7abb38b82058b4312afR69

can't say if this is still needed though.

@axic
Copy link
Member

axic commented Dec 3, 2018

Need to add a test case to verify this. So basically the test case would use findLinkReferences with an old style link reference (__LibraryName_____...) ?

@yann300
Copy link
Contributor Author

yann300 commented Dec 4, 2018

So basically the test case would use findLinkReferences with an old style link reference (LibraryName___...)

right I believe so, and the output should be compliant with JSON standard.

@axic axic force-pushed the yann300-patch-2 branch 2 times, most recently from ab0d777 to e0c40dd Compare December 12, 2018 22:38
@axic axic force-pushed the yann300-patch-2 branch 2 times, most recently from be49dd5 to 30c8fe1 Compare November 6, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants