Remove unnecessary Hardhat-related CI jobs #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit fixes an unrelated thing in the CI: it assumes that the Hardhat repo only has releases related to Hardhat, but we also publish our plugins releases there. This means that if the latest release is a plugin, the job fails. I fixed that by getting all releases, and getting the first one whose tag starts with The node-v10 job is still failing, but that also seems unrelated to my changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #752, this removes two Hardhat-related jobs that are not necessary and that will stop working soon when we remove those tests from the Hardhat repo.