Purge using namespace std from libsolidity/interface #14492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
force-pushed
the
purge-using-namespace-from-libsolidity-interface
branch
from
5647039
to
36d66ad
Compare
nikola-matic
force-pushed
the
purge-using-namespace-from-libsolidity-interface
branch
from
36d66ad
to
342ba03
Compare
cameel
approved these changes
Aug 16, 2023
| externalFunctions[sig] = gasToJson(gasEstimator.functionalEstimation(*items, sig)); | ||
| } | ||
|
|
||
| if (contract.fallbackFunction()) | ||
| /// This needs to be set to an invalid signature in order to trigger the fallback, | ||
| /// without the shortcut (of CALLDATSIZE == 0), and therefore to receive the upper bound. | ||
| /// An empty string ("") would work to trigger the shortcut only. | ||
| /// An empty std::string ("") would work to trigger the shortcut only. |
There was a problem hiding this comment.
Suggested change
| /// An empty std::string ("") would work to trigger the shortcut only. | |
| /// An empty string ("") would work to trigger the shortcut only. |
|
|
||
| // If the link reference does not contain a colon, assume that the file name is missing and | ||
| // the whole string represents the library name. | ||
| // the whole std::string represents the library name. |
There was a problem hiding this comment.
Suggested change
| // the whole std::string represents the library name. | |
| // the whole string represents the library name. |
There was a problem hiding this comment.
Thought these were the ones from the other PR that I've already fixed, and merged before looking. I've fixed both of these in the other PR (after rebase) - #14493.
nikola-matic
deleted the
purge-using-namespace-from-libsolidity-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #14403