Instantiation registration pass in new analysis #14735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
new-analysis-instantiation-registration
branch
from
9c0d9b8
to
46c24c4
Compare
cameel
commented
Dec 15, 2023
Comment on lines
+613
to
+624
| if (typeClassDefinition) | ||
| // We may have not visited the type class definition yet. Do it just in case. | ||
| // TODO: Type classes should be processed in a separate pass to avoid this out-of-order visitation. | ||
| typeClassDefinition->accept(*this); |
There was a problem hiding this comment.
cameel
force-pushed
the
new-analysis-instantiation-registration
branch
from
46c24c4
to
ac95ace
Compare
cameel
added
the
has dependencies
cameel
force-pushed
the
new-analysis-instantiation-registration
branch
3 times, most recently
from
f991650
to
08c856c
Compare
cameel
force-pushed
the
new-analysis-move-builtin-class-registration-to-class-registration-pass
branch
from
16e30e4
to
a674c85
Compare
github-actions
bot
added
the
stale
cameel
removed
the
stale
github-actions
bot
added
the
stale
cameel
removed
the
stale
cameel
force-pushed
the
new-analysis-move-builtin-class-registration-to-class-registration-pass
branch
from
a674c85
to
868f0bd
Compare
cameel
force-pushed
the
new-analysis-instantiation-registration
branch
from
08c856c
to
858d874
Compare
github-actions
bot
added
the
stale
cameel
removed
the
stale
cameel
force-pushed
the
new-analysis-move-builtin-class-registration-to-class-registration-pass
branch
from
868f0bd
to
56cfd69
Compare
cameel
force-pushed
the
new-analysis-instantiation-registration
branch
from
858d874
to
78d9d43
Compare
cameel
force-pushed
the
new-analysis-move-builtin-class-registration-to-class-registration-pass
branch
from
56cfd69
to
66309c7
Compare
cameel
force-pushed
the
new-analysis-move-builtin-class-registration-to-class-registration-pass
branch
from
66309c7
to
2b410a7
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
cameel
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #14734.
Prerequisite for #14721.
This is pass 2.25 from Experimental Type System Notes:
It will allow me to remove out-of order visitation of instantiations from #14721.