Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Styling and Documentation Errors #15588

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

cypherpepe
Copy link
Contributor

Description

This pull request addresses two issues:

  1. Styling Fix in custom.css

    • Corrected the box-shadow property for the .wy-side-nav-search class to ensure proper CSS syntax by adding the missing px units. developer.mozilla.org
  2. Documentation Typo Fix in contributing.rst

    • Corrected a typo: changed "requry" to "require" for improved clarity and correctness.

The box-shadow property in .wy-side-nav-search was incorrectly specified with four values, omitting the necessary units.
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Contributor

@mehtavishwa30 mehtavishwa30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @cypherpepe! Approving and merging now. :)

@mehtavishwa30 mehtavishwa30 merged commit 6fc4c03 into ethereum:develop Nov 26, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants