Update python in CI to get latest codespell #15589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I could just bump the current image to 3.13 but this would require manual bumping in the future again.
- This makes it move convenient to use on the CLI
cameel
force-pushed
the
update-python-for-latest-codespell
branch
from
e982557
to
7039ab6
Compare
ekpyron
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding a lot of typos in PRs like #15550 even though we have a codespell job that should be detecting them automatically. Apparently this is because we're using
cimg/python:3.6image, which ships an old version of codespell (2.2.1). The latest one has a better dictionary that does detect the typos.This PR replaces
cimg/python:3.6with our Ubuntu image, which we keep up to date.It also adds a config file for codespell to make it easier to run it locally with the right arguments. It's now enough to simply run
codespellwithout arguments.