Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASTNodeRegistry to AST #15833

Open
wants to merge 3 commits into
base: add_yul_name_label_registry
Choose a base branch
from

Conversation

clonker
Copy link
Member

@clonker clonker commented Feb 5, 2025

Depends on PR #15823.

  • adds ASTNodeRegistry to AST as member
  • introduces ASTNodeRegistryBuilder into AsmParser and AsmJsonImporter with the caveat that the generated ids are not yet incorporated into the components of the AST themselves (ie YulName still points to YulString)

@clonker clonker added the has dependencies The PR depends on other PRs that must be merged first label Feb 5, 2025
@clonker clonker requested review from cameel and aarlt February 5, 2025 11:56
@clonker clonker force-pushed the add_yul_name_label_registry branch from cd00616 to 2b9295d Compare February 5, 2025 12:10
@clonker clonker requested a review from blishko February 5, 2025 12:17
@clonker clonker force-pushed the add_yul_name_label_registry branch from 2b9295d to bf80a01 Compare February 5, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant