Skip to content

AssemblyItem asserts that it's not implicity constructed by instruction for swapn/dupn #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

clonker
Copy link
Member

@clonker clonker commented Apr 27, 2025

Otherwise this can lead to AssemblyItems that have the instruction set but not the corresponding type. SWAPN/DUPN should only ever be created by the AssemblyItem::swapN AssemblyItem::dupN helper functions.

@clonker clonker force-pushed the assert_swapn_dupn_in_assemblyitem branch from b6b074b to ab279e9 Compare April 28, 2025 15:44
@clonker clonker requested a review from cameel April 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant