EIP4758 test cases #1024
Draft
EIP4758 test cases #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can use lllc or yul in code src |
winsvega
requested changes
Dec 14, 2022
| "gas" : -1, | ||
| "value" : -1 | ||
| }, | ||
| "network" : [">=EIP4758"], |
There was a problem hiding this comment.
need to convert to Merge+4758
| }, | ||
| "expect" : [ | ||
| { | ||
| "indexes" : { |
There was a problem hiding this comment.
indexes can be removed as it is -1 by default
| "095e7baea6a6c7c4c2dfeb977efac326af552d87" : { | ||
| "balance" : "1000000000000000000", | ||
| "// code" : "PUSH20 095e7baea6a6c7c4c2dfeb977efac326af552d87 SELFDESTRUCT", | ||
| "code" : ":raw 0x73095e7baea6a6c7c4c2dfeb977efac326af552d87ff", |
There was a problem hiding this comment.
can use lllc here or yul
|
Would be good to add tests that check whether execution stops after SENDALL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SENDALLwith currently-executing contract as the beneficiary returns execution to the calling frame and leaves the contract which executedSENDALLin the state after the transaction finishes.SENDALLwith non-self beneficiary transfers the balance of the invoking account to the beneficiary, ends execution of the current frame. The account which executedSENDALLremains in the state after the transaction finishes.