Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: bump 0x100 test addresses to 0x1000 #1401

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

dev: bump 0x100 test addresses to 0x1000 #1401

wants to merge 4 commits into from
+600 −610

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 18, 2024

Following the previous PR #1372, I updated another set of test fillers from addresses 0x100 to addresses 0x1000.

I also re-filled these tests.

@winsvega
Copy link
Collaborator

some tests not filled, why?

@enitrat
Copy link
Contributor Author

enitrat commented Oct 24, 2024 •
edited
Loading

I'm not sure, which ones?

@winsvega
Copy link
Collaborator 

est Case "stEIP150singleCodeGasPrices": (23 of 85)

Error: Test /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostJump.json is outdated. Filler hash is different! ('5aef' != '858f')  (BCGeneralStateTests/stEIP150singleCodeGasPrices/gasCostJumpFiller, step: CheckFiller)

Error: Test /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturn.json is outdated. Filler hash is different! ('f4e4' != '5eba')  (BCGeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturnFiller, step: CheckFiller)

Error: Tests are not generated (forgot --filltests?): 

 /home/travis/build/ethereum/tests/src/GeneralStateTestsFiller/stEIP150singleCodeGasPrices/gasCostJumpFiller.yml => /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostJump.json

 /home/travis/build/ethereum/tests/src/GeneralStateTestsFiller/stEIP150singleCodeGasPrices/gasCostReturnFiller.yml => /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturn.json

est Case "stEIP150singleCodeGasPrices": (23 of 85)

Error: Test /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostJump.json is outdated. Filler hash is different! ('5aef' != '858f')  (BCGeneralStateTests/stEIP150singleCodeGasPrices/gasCostJumpFiller, step: CheckFiller)

Error: Test /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturn.json is outdated. Filler hash is different! ('f4e4' != '5eba')  (BCGeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturnFiller, step: CheckFiller)

Error: Tests are not generated (forgot --filltests?): 

 /home/travis/build/ethereum/tests/src/GeneralStateTestsFiller/stEIP150singleCodeGasPrices/gasCostJumpFiller.yml => /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostJump.json

 /home/travis/build/ethereum/tests/src/GeneralStateTestsFiller/stEIP150singleCodeGasPrices/gasCostReturnFiller.yml => /home/travis/build/ethereum/tests/BlockchainTests/GeneralStateTests/stEIP150singleCodeGasPrices/gasCostReturn.json

missing --fillchain ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @winsvega