Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add holesky network type #1587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Nov 20, 2024

What was wrong?

image

Devnets and testnets are important for ensuring the robustness of Ethereum to continue shipping upgrades. As Portal gets integrated and becomes more important infrastructure for L1's clients, the idea is that Portal would be run by default on testnets, the same way any default feature is run on both main nets and testnets.

How was it fixed?

I am adding a network outline for Holesky as it is the newest testnet, goreli is now discontinued. Future testnets won't have a pre-merge phase. I believe sepolia will be the last testnet (which is still supported) to have any per-merge data.

Anyways there isn't a rush to add sepolia, adding holesky should allow me to fix most of our hardcoded mainnet stuff.

Work left to do in follow-up PR's

  • add testing that testnet values work might be an optional flag in hive or some tests in the trin repo, this will be on on-going thing
  • Make Trin work with networks other than the mainnet. This will probably result in multiple PRs over time.

In short this is the start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant