Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax ethpm canonical address requirement #1380

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Relax ethpm canonical address requirement #1380

merged 1 commit into from
Jul 12, 2019

Conversation

njgheorghita
Copy link
Contributor

What was wrong?

Updated ethpm to use web3's validate_address.

from #1379 (comment)

Having to convert to a canonical address feels out of place now that ethpm is embedded with web3.py. Seems like it should follow the same standard of the rest of web3.py: either a checksummed address or a canonical address is fine.

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the ethpm-relax-address-constraints branch from 08c5501 to 59d28df Compare July 11, 2019 20:32
@njgheorghita njgheorghita force-pushed the ethpm-relax-address-constraints branch from 59d28df to f2f40c7 Compare July 11, 2019 20:37
@njgheorghita njgheorghita merged commit 5bd581f into ethereum:master Jul 12, 2019
@njgheorghita njgheorghita deleted the ethpm-relax-address-constraints branch July 12, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipermerriam pipermerriam pipermerriam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njgheorghita @pipermerriam