Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/home issues #60

Merged
merged 4 commits into from
Jul 12, 2020
Merged

Features/home issues #60

merged 4 commits into from
Jul 12, 2020

Conversation

0xPetra
Copy link
Collaborator

@0xPetra 0xPetra commented Jul 12, 2020 •
edited
Loading

What's new?

Solving home issues.

Changes include

  • 56 Bugfix: Change wording of a button in /events
  • 57 New feature: Add section "upcoming events" in /home
  • 58 Bugfix: "Join our meetup" button needs a fix in the spacing when changing languages
  • 59 New feature: Change number of members of the meetup group in the landing page

Test steps to reproduce

Gif / Screenshots

Self-QA Checklist

  • I have tested this code
  • I have updated the README (if needed)
  • This branch has been rebased from dev before creating the pull-request
  • Pull-request build has passed

@0xPetra 0xPetra requested a review from ragonzal July 12, 2020 15:01
ragonzal
ragonzal approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@ragonzal ragonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @francopetra. Just a comment, I made a little change regarding the endpoint that was hardcoded. There's a file (src/lib/api.js) with this endpoints.

@ragonzal ragonzal merged commit c38f766 into master Jul 12, 2020
@ragonzal ragonzal deleted the features/home-issues branch July 12, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragonzal ragonzal ragonzal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xPetra @ragonzal