improvs

ethereumjs · Oct 4, 2024 · 65fbf73 · 65fbf73
1 parent 3dc4d4c
commit 65fbf73
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/client/src/rpc/modules/engine/engine.ts b/packages/client/src/rpc/modules/engine/engine.ts
@@ -1523,6 +1523,16 @@ export class Engine {
   }
 
   private async getBlobsV1(params: [[Bytes32]]): Promise<(BlobAndProofV1 | null)[]> {
+    const blobGasLimit = this.config.chainCommon.param('maxblobGasPerBlock')
+    const blobGasPerBlob = this.config.chainCommon.param('blobGasPerBlob')
+    const allowedBlobsPerBlock = blobGasLimit / blobGasPerBlob
+    if (params[0].length > allowedBlobsPerBlock) {
+      throw {
+        code: TOO_LARGE_REQUEST,
+        message: `More than allowedBlobsPerBlock=${allowedBlobsPerBlock} hashes queried`,
+      }
+    }
+
     const blobsAndProof: (BlobAndProofV1 | null)[] = []
     for (const versionedHashHex of params[0]) {
       blobsAndProof.push(this.service.txPool.blobsAndProofsByHash.get(versionedHashHex) ?? null)

diff --git a/packages/client/src/service/txpool.ts b/packages/client/src/service/txpool.ts
@@ -399,12 +399,10 @@ export class TxPool {
   }
 
   pruneBlobsAndProofsCache() {
-    // currently common.param errors when not achieved cancun hardfork to do the below calculation
-    // const blobGasLimit = this.config.chainCommon.param('maxblobGasPerBlock')
-    // const blobGasPerBlob = this.config.chainCommon.param('blobGasPerBlob')
-    //
-    // A better way could be figured out to get allowedBlobsPerBlock
-    const allowedBlobsPerBlock = 6
+    const blobGasLimit = this.config.chainCommon.param('maxblobGasPerBlock')
+    const blobGasPerBlob = this.config.chainCommon.param('blobGasPerBlob')
+    const allowedBlobsPerBlock = Number(blobGasLimit / blobGasPerBlob)
+
     const pruneLength =
       this.blobsAndProofsByHash.size - allowedBlobsPerBlock * this.config.blobsAndProofsCacheBlocks
     let pruned = 0