Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateManager: stateless verkle statemanager #2328

Closed
wants to merge 63 commits into from

Conversation

gabrocheleau
Copy link
Contributor

This PR builds on #1721 to resume work on the stateless verkle state manager.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #2328 (aa0ff6b) into master (da187d4) will decrease coverage by 1.73%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client ?
common 95.74% <100.00%> (+<0.01%) ⬆️
devp2p ?
ethash ?
evm 79.37% <100.00%> (-0.02%) ⬇️
rlp ?
statemanager ?
trie 90.36% <ø> (ø)
tx 94.43% <ø> (+0.04%) ⬆️
util 85.19% <ø> (+0.12%) ⬆️
vm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau gabrocheleau changed the title VM: stateless verkle statemanager StateManager: stateless verkle statemanager Oct 4, 2022
Pemburu88
Pemburu88 previously approved these changes Oct 28, 2022
@paulmillr
Copy link
Member

I know the current version is basically prototyping, but at some point the wasm binary will need to be replaced with JS, because wasm is not supported in all environments, due to CSP, or other reasons.

One example that cannot use wasm is Metamask.

@holgerd77
Copy link
Member

I know this will be some substantial amount of work (would count in 2 days or so) but it would also be good for this to make the switch to develop-v7 relatively soon (rather weeks than months, so: before the releases). This would generally be necessary at some point and if we do early this could help a lot to see if the structures we built up there (or: changed) are suitable to allow for an easy integration of other state managers.

@gabrocheleau
Copy link
Contributor Author

I know this will be some substantial amount of work (would count in 2 days or so) but it would also be good for this to make the switch to develop-v7 relatively soon (rather weeks than months, so: before the releases). This would generally be necessary at some point and if we do early this could help a lot to see if the structures we built up there (or: changed) are suitable to allow for an easy integration of other state managers.

Absolutely! I was thinking about that while contributing to the buffers -> uint8array transition. Definitely makes sense to do this sooner rather than latter. I am planning on tackling this over the weekend.

@holgerd77
Copy link
Member

I know this will be some substantial amount of work (would count in 2 days or so) but it would also be good for this to make the switch to develop-v7 relatively soon (rather weeks than months, so: before the releases). This would generally be necessary at some point and if we do early this could help a lot to see if the structures we built up there (or: changed) are suitable to allow for an easy integration of other state managers.

Absolutely! I was thinking about that while contributing to the buffers -> uint8array transition. Definitely makes sense to do this sooner rather than latter. I am planning on tackling this over the weekend.

Pretty cool! 🙂 👍

@gabrocheleau
Copy link
Contributor Author

Superseded by #2643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants