Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGTERM in client #2921

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Handle SIGTERM in client #2921

merged 4 commits into from
Jul 29, 2023

Conversation

acolytec3
Copy link
Contributor

This PR supersedes #2899 (by documenting the Docker approved way to start node in Docker containers) and also adds a handler for the SIGTERM kernel signal that is often used to shut down Docker containers.

@acolytec3 acolytec3 requested a review from g11tech July 28, 2023 17:39
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #2921 (b50c977) into master (174772e) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 88.39% <ø> (+0.11%) ⬆️
common 98.64% <ø> (ø)
ethash ∅ <ø> (∅)
evm 69.95% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 85.16% <ø> (ø)
trie 90.14% <ø> (-0.04%) ⬇️
tx 95.96% <ø> (ø)
util 86.77% <ø> (ø)
vm 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha so SIGTERM was not being handled, lgtm

@acolytec3 acolytec3 merged commit 654c67a into master Jul 29, 2023
41 checks passed
@acolytec3 acolytec3 deleted the handle-sigterm branch July 29, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants