Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client: move libp2p folder to archive #2926

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Client: move libp2p folder to archive #2926

merged 5 commits into from
Jul 31, 2023

Conversation

holgerd77
Copy link
Member

Small PR to have the libp2p archived folder a bit less present in the folder structure.

acolytec3
acolytec3 previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #2926 (e777e5f) into master (654c67a) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 88.32% <ø> (+0.04%) ⬆️
common 98.64% <ø> (ø)
ethash ∅ <ø> (∅)
evm 69.95% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 85.16% <ø> (ø)
trie 90.14% <ø> (ø)
tx 95.96% <ø> (ø)
util 86.77% <ø> (ø)
vm 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 mentioned this pull request Jul 31, 2023
Open
acolytec3
acolytec3 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, p2

@holgerd77 holgerd77 merged commit 5669e6b into master Jul 31, 2023
41 checks passed
@holgerd77 holgerd77 deleted the client-move-libp2p-folder-to-archive branch July 31, 2023 17:13
@holgerd77
Copy link
Member Author

Admin-merged, since one unrelated client integration test always failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: client PR state: needs review type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerd77 @acolytec3