Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holesky dns url to supported chains info #3088

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

scorbajio
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3088 (e45527c) into master (9579e5e) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client ?
common 98.19% <100.00%> (+<0.01%) ⬆️
ethash ?
evm 71.87% <ø> (ø)
rlp ?
statemanager 90.23% <ø> (ø)
trie 90.25% <ø> (-0.14%) ⬇️
tx 96.36% <ø> (ø)
util 86.97% <ø> (ø)
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Rebased this via UI

@holgerd77
Copy link
Member

Did you try and test here (e.g. via activating debug logs for devp2p) if DNS connection is going on successfully?

@scorbajio
Copy link
Contributor Author

scorbajio commented Oct 8, 2023

Did you try and test here (e.g. via activating debug logs for devp2p) if DNS connection is going on successfully?

Seems to be working as expected:

[10-08|11:31:49] INFO Initializing Ethereumjs client version=v0.8.1 network=holesky chainId=17000 

...

2023-10-08T18:31:50.174Z devp2p:dns:dns got new peer candidate from DNS address=23.124.84.197
2023-10-08T18:31:50.313Z devp2p:dns:dns got new peer candidate from DNS address=194.33.40.147
2023-10-08T18:31:50.430Z devp2p:dns:dns got new peer candidate from DNS address=194.33.40.82
2023-10-08T18:31:50.504Z devp2p:dns:dns got new peer candidate from DNS address=159.203.110.190
2023-10-08T18:31:50.594Z devp2p:dns:dns got new peer candidate from DNS address=194.33.40.151

...

[10-08|11:31:55] WARN Engine RPC endpoint not activated on a post-Merge HF setup.
[10-08|11:31:55] INFO ---------------------------
[10-08|11:31:55] INFO Client started successfully
[10-08|11:31:55] INFO ---------------------------

Can check by running DEBUG=devp2p:dns:* npm run client:start -- --discDns --network "holesky"

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shippit.

@scorbajio scorbajio merged commit f4a4a92 into master Oct 9, 2023
43 checks passed
@scorbajio scorbajio deleted the update-holesky-dns-url branch October 9, 2023 18:36
@holgerd77
Copy link
Member

@scorbajio cool, thanks for testing! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants