Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verkle: add verkle-trie package #3111

Closed
wants to merge 62 commits into from

Conversation

gabrocheleau
Copy link
Contributor

No description provided.

gabrocheleau and others added 30 commits July 29, 2023 10:50
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #3111 (e05168b) into verkle/verkle-package (3ccfc3f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client 87.72% <ø> (+0.04%) ⬆️
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.87% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 90.30% <ø> (ø)
trie 89.40% <ø> (-0.34%) ⬇️
tx 96.36% <ø> (ø)
util 86.31% <ø> (ø)
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from verkle/verkle-package to master October 26, 2023 07:19
@holgerd77
Copy link
Member

This can now be closed, right?

@gabrocheleau
Copy link
Contributor Author

Technically no, since this is a new thing (refactoring kev's verkle-trie-js package), but I'll close and create a new one regardless as it's going to be cleaner anyway.

@holgerd77
Copy link
Member

Ah, ok 🤯, again this naming confusion, I thought this would refer to our own package and therefore be redundant.

@gabrocheleau
Copy link
Contributor Author

Ah, ok 🤯, again this naming confusion, I thought this would refer to our own package and therefore be redundant.

Yeah agreed, will bring this up to kev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants