Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Util internal tests and fix #3112

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Util internal tests and fix #3112

merged 10 commits into from
Oct 25, 2023

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Oct 23, 2023 •
edited
Loading

This change adds tests for the util package internal.ts functions and fixes a bug in the fromUtf8 function that double-adds the hex prefix to the returned value.

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #3112 (653bb34) into master (61af5c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.27% <ø> (ø)
client 87.51% <ø> (-0.05%) ⬇️
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.87% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 90.30% <ø> (ø)
trie 90.35% <ø> (ø)
tx 96.36% <ø> (ø)
util 88.26% <100.00%> (+0.55%) ⬆️
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, tests look great in general! 😄

packages/util/src/internal.ts Show resolved Hide resolved
packages/util/test/internal.spec.ts Show resolved Hide resolved
packages/util/test/internal.spec.ts Show resolved Hide resolved
@holgerd77
Copy link
Member

Great new tests and great review! 🤩

@holgerd77
Copy link
Member

Updated this via UI

holgerd77
holgerd77 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

jochem-brouwer
jochem-brouwer approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 25696ac into master Oct 25, 2023
43 checks passed
@holgerd77 holgerd77 deleted the util-internal-tests-and-fix branch October 25, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: util PR state: needs review type: bug type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scorbajio @holgerd77 @jochem-brouwer