Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateManager: stateless verkle state manager #3139

Merged
merged 99 commits into from
Dec 6, 2023

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Nov 3, 2023

Supersedes #2643 by rebasing the work on the current master branch w/ the verkle package.

run kaustinen2 sample network tests
DEBUG=ethjs,vm:*,evm:*,sm:* npx vitest run test/rpc/engine/kaustinen2.spec.ts

OR run actual kaustinen2 network:

  1. DEBUG=ethjs,vm:*,evm:* npm run client:start:ts -- --dataDir /data/teme --network kaustinen --rpc --rpcEngine --rpcEngineAuth false
  2. clone https://github.com/ChainSafe/lodestar-quickstart , do vi kaustinen.vars and remove the checkpointSyncUrl from lodestar args input and run ./setup.sh --dataDir k2data --network kaustinen --justCL to run lodestar to feed ethereumjs blocks

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #3139 (510ef25) into master (1bb7bc2) will decrease coverage by 0.93%.
The diff coverage is 72.26%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.52% <61.53%> (-1.28%) ⬇️
blockchain 91.60% <85.00%> (-0.01%) ⬇️
client 84.54% <75.68%> (-0.39%) ⬇️
common 98.25% <97.58%> (+0.05%) ⬆️
devp2p 82.11% <ø> (ø)
ethash ?
evm 73.54% <100.00%> (+<0.01%) ⬆️
statemanager 85.72% <68.68%> (-4.39%) ⬇️
trie 89.72% <ø> (-0.05%) ⬇️
tx ?
util 89.05% <50.00%> (-0.16%) ⬇️
vm 80.83% <34.48%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau gabrocheleau force-pushed the stateManager/statelessVerkleStateManager branch from df3bad1 to 870f350 Compare November 4, 2023 10:03
@gabrocheleau gabrocheleau marked this pull request as ready for review December 6, 2023 01:24
packages/statemanager/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me for merging in main codebase after we resolve the peer dependancy for the wasm

g11tech
g11tech previously approved these changes Dec 6, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg from my side

@gabrocheleau gabrocheleau dismissed holgerd77’s stale review December 6, 2023 16:37

All comments have been addressed

@gabrocheleau gabrocheleau merged commit aac2bef into master Dec 6, 2023
45 of 46 checks passed
@holgerd77 holgerd77 deleted the stateManager/statelessVerkleStateManager branch May 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants