Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: rename createHeader functions #3558

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Block: rename createHeader functions #3558

merged 2 commits into from
Aug 5, 2024

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented Aug 5, 2024 •
edited
Loading

Followup to #3550

Updates createHeader... functions to more explicit createBlockHeader...

  • createHeader > createBlockHeader
  • createHeaderFromRLP > createBlockHeaderFromRLP
  • createHeaderFromValuesArray > createBlockHeaderFromValuesArray

acolytec3
acolytec3 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit ca24a8c into master Aug 5, 2024
34 checks passed
@acolytec3 acolytec3 deleted the rename-createheader branch August 5, 2024 19:13
@holgerd77
Copy link
Member

Also here: thanks for adressing so quickly! 🙏 👍 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
breaking package: block package: blockchain package: client package: devp2p package: ethash package: vm PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottyPoi @holgerd77 @acolytec3