Block consensus methods refactoring

[scorbajio]

This change reforms certain consensus-related Block and BlockHeader class methods into standalone functions, as proposed in #3563.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.83%. Comparing base (4470cc3) to head (831e1d6).
Report is 2 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
block	?
client	?
tx	77.77% <ø> (ø)
wallet	0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[scorbajio]

Testing the bundle size with a standard code path:

import { Block } from '@ethereumjs/block'
import { Chain, Common, Hardfork } from '@ethereumjs/common'
const common = new Common({ chain: Chain.Mainnet, hardfork: Hardfork.London })

const block = Block.fromBlockData(
  {
    header: {
      baseFeePerGas: BigInt(10),
      gasLimit: BigInt(100),
      gasUsed: BigInt(60),
    },
  },
  { common }
)

console.log(Number(block.header.calcNextBaseFee())) // 11

before: 325.8kb
after: 322.9kb
delta: -2.9kb

[scorbajio]

Testing the bundle size with a standard code path:

import { Block } from '@ethereumjs/block'
import { Chain, Common, Hardfork } from '@ethereumjs/common'
const common = new Common({ chain: Chain.Mainnet, hardfork: Hardfork.London })

const block = Block.fromBlockData(
  {
    header: {
      baseFeePerGas: BigInt(10),
      gasLimit: BigInt(100),
      gasUsed: BigInt(60),
    },
  },
  { common }
)

console.log(Number(block.header.calcNextBaseFee())) // 11

before: 325.8kb after: 322.9kb delta: -2.9kb

Taking a look at the output bundle, it seems like some of the consensus functions are still being included in the final output bundle, will have to look into why this is happening as the code path doesn't seem to use them.

[holgerd77]

Nice, this looks great now! 🤩

[holgerd77]

(interesting failure in client tests though)

[acolytec3]

LGTM

Further comments have confirmed that the code is good now.

[holgerd77]

Ah, looking through this I have to say, this feels really good to have this consensus code and this specific methods out of core Block, also changes all look good, had a final look over the code changes! Thanks Amir, nice work! 👍 🙂