Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example test runner: make script more readable / ensure examples do not process.exit #3585

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

jochem-brouwer
Copy link
Member

The examples test runner tries to run each example in a package, and if one of them throws, the npm run examples will fail (and will also throw on CI). However, some examples have process.exit, if this is hit, the process exits with a successful code and any errors which might have thrown could be discarded (depending if the error gets handled first, or the process.exit)

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 40.75%. Comparing base (4470cc3) to head (659d428).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 71.90% <ø> (-1.55%) ⬇️
blockchain 84.92% <ø> (?)
client ?
common 89.68% <ø> (?)
devp2p 0.00% <ø> (?)
evm 64.28% <ø> (?)
genesis 0.00% <ø> (?)
statemanager 65.93% <ø> (?)
trie 52.02% <ø> (?)
tx ?
util 69.89% <ø> (?)
vm 58.77% <0.00%> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 merged commit 9cb2ca8 into master Aug 14, 2024
35 of 36 checks passed
@acolytec3 acolytec3 deleted the fix-examples-test-runner branch August 14, 2024 01:30
@holgerd77
Copy link
Member

Just to confirm: so this is really no problem on my side (regarding examples creation or whatever)! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants