Monorepo: Fix platform-Specific Dependencies npm CLI Bug #3648
+4,324
−2,300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
fix-platform-specific-dependencies-npm-cli-bug
branch
from
fd1e4a4
to
1efbb5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
approved these changes
Sep 10, 2024
holgerd77
deleted the
fix-platform-specific-dependencies-npm-cli-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports over a fix I have already applied on #3643 on
maintenance-v8fixing a bug for platform-specific dependencies not being included in apackage-lock.jsonfile, resulting in an...Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.... error when running the
npm run visualize:bundlecommand on Mac OS (+ potentially other linux machines?).Fix is applied along this comment, the wider thread/issue directly deals with the core issue.