monorepo: Normalize exception values in error handling

config/eslint.cjs

@@ -56,7 +56,8 @@ module.exports = {
       'error',
       { argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
     ],
-    '@typescript-eslint/no-redeclare': ['error'],
+    '@typescript-eslint/no-redeclare': 0,
+    'no-ex-assign': 0,
     '@typescript-eslint/no-unnecessary-condition': 'off',
     '@typescript-eslint/prefer-nullish-coalescing': 'error',
     '@typescript-eslint/restrict-plus-operands': 'off',

config/tsconfig.json

@@ -14,6 +14,7 @@
     "strict": true,
     "target": "es2020",
     "lib": ["ES2020", "DOM"],
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "useUnknownInCatchVariables": false
   }
 }

packages/block/src/block/block.ts

@@ -607,13 +607,13 @@ export class Block {
     let hash = ''
     try {
       hash = bytesToHex(this.hash())
-    } catch (e: any) {
+    } catch {
       hash = 'error'
     }
     let hf = ''
     try {
       hf = this.common.hardfork()
-    } catch (e: any) {
+    } catch {
       hf = 'error'
     }
     let errorStr = `block number=${this.header.number} hash=${hash} `

packages/block/src/header/header.ts

@@ -806,13 +806,13 @@ export class BlockHeader {
     let hash = ''
     try {
       hash = bytesToHex(this.hash())
-    } catch (e: any) {
+    } catch {
       hash = 'error'
     }
     let hf = ''
     try {
       hf = this.common.hardfork()
-    } catch (e: any) {
+    } catch {
       hf = 'error'
     }
     let errorStr = `block header number=${this.number} hash=${hash} `

packages/block/test/block.spec.ts

@@ -154,7 +154,10 @@ describe('[Block]: block functions', () => {
     try {
       createBlockFromRLP(blockRlp, { common })
       assert.ok(true, 'should pass')
-    } catch (error: any) {
+    } catch (error) {
+      if (!(error instanceof Error)) {
+        error = new Error(error)
+      }
       assert.fail('should not throw')
     }
   })
@@ -165,7 +168,10 @@ describe('[Block]: block functions', () => {
     try {
       createBlockFromRPC(testdataFromRPCGoerliData, [], { common })
       assert.ok(true, 'does not throw')
-    } catch (error: any) {
+    } catch (error) {
+      if (!(error instanceof Error)) {
+        error = new Error(error)
+      }
       assert.fail('error thrown')
     }
   })
@@ -184,7 +190,10 @@ describe('[Block]: block functions', () => {
     try {
       await block.validateData()
       assert.fail('should throw')
-    } catch (error: any) {
+    } catch (error) {
+      if (!(error instanceof Error)) {
+        error = new Error(error)
+      }
       assert.ok((error.message as string).includes('invalid transaction trie'))
     }
   })
@@ -205,7 +214,10 @@ describe('[Block]: block functions', () => {
     try {
       await block.validateData()
       assert.fail('should throw')
-    } catch (error: any) {
+    } catch (error) {
+      if (!(error instanceof Error)) {
+        error = new Error(error)
+      }
       assert.ok((error.message as string).includes('unsigned'))
     }
   })
@@ -237,7 +249,10 @@ describe('[Block]: block functions', () => {
     try {
       await block.validateData()
       assert.fail('should throw')
-    } catch (error: any) {
+    } catch (error) {
+      if (!(error instanceof Error)) {
+        error = new Error(error)
+      }
       assert.ok((error.message as string).includes('invalid uncle hash'))
     }
   })
@@ -260,7 +275,10 @@ describe('[Block]: block functions', () => {
       try {
         await fn
         assert.fail('should throw')
-      } catch (e: any) {
+      } catch (e) {
+        if (!(e instanceof Error)) {
+          e = new Error(e)
+        }
         assert.ok((e.message as string).includes(errorMsg))
       }
     }

packages/block/test/eip1559block.spec.ts

@@ -72,7 +72,10 @@ describe('EIP1559 tests', () => {
         },
       )
       assert.fail('should throw when baseFeePerGas is not set to initial base fee')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       const expectedError = 'Initial EIP1559 block does not have initial base fee'
       assert.ok(
         e.message.includes(expectedError),
@@ -96,7 +99,10 @@ describe('EIP1559 tests', () => {
       )
       ;(header as any).baseFeePerGas = undefined
       await (header as any)._genericFormatValidation()
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       const expectedError = 'EIP1559 block has no base fee field'
       assert.ok(
         e.message.includes(expectedError),
@@ -141,7 +147,10 @@ describe('EIP1559 tests', () => {
         },
       )
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(e.message.includes('base fee'), 'should throw on wrong initial base fee')
     }
   })
@@ -199,7 +208,10 @@ describe('EIP1559 tests', () => {
         },
       )
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(e.message.includes('too much gas used'), 'should throw when elasticity is exceeded')
     }
   })
@@ -325,7 +337,10 @@ describe('EIP1559 tests', () => {
     try {
       header.validateGasLimit(genesis.header)
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(
         e.message.includes('gas limit increased too much'),
         'should throw if gas limit is increased too much (HF transition block)',
@@ -349,7 +364,10 @@ describe('EIP1559 tests', () => {
     try {
       header.validateGasLimit(block1.header)
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(
         e.message.includes('gas limit increased too much'),
         'should throw if gas limit is increased too much (post-HF transition block)',
@@ -375,7 +393,10 @@ describe('EIP1559 tests', () => {
     try {
       header.validateGasLimit(genesis.header)
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(
         e.message.includes('gas limit decreased too much'),
         'should throw if gas limit is decreased too much (HF transition block)',
@@ -399,7 +420,10 @@ describe('EIP1559 tests', () => {
     try {
       header.validateGasLimit(block1.header)
       assert.fail('should throw')
-    } catch (e: any) {
+    } catch (e) {
+      if (!(e instanceof Error)) {
+        e = new Error(e)
+      }
       assert.ok(
         e.message.includes('gas limit decreased too much'),
         'should throw if gas limit is decreased too much (post-HF transition block)',

packages/block/test/from-rpc.spec.ts

@@ -223,7 +223,10 @@ describe('[fromJSONRPCProvider]', () => {
     try {
       await createBlockFromJSONRPCProvider(provider, bytesToHex(randomBytes(32)), {})
       assert.fail('should throw')
-    } catch (err: any) {
+    } catch (err) {
+      if (!(err instanceof Error)) {
+        err = new Error(err)
+      }
       assert.ok(
         err.message.includes('No block data returned from provider'),
         'returned correct error message',