Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dev dependencies #3710

Merged
merged 15 commits into from
Oct 1, 2024
Merged

Clean up dev dependencies #3710

merged 15 commits into from
Oct 1, 2024

Conversation

acolytec3
Copy link
Contributor

Removes vitest-plugin-node-polyfills from our dev dependencies and fixes related tests
Removes @ethersproject/abi since it was only used to derive calldata for a single test

@acolytec3 acolytec3 added type: tests dependencies Pull requests that update a dependency file labels Sep 29, 2024
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, however the examples also seem to have a dependency on ethersproject/abi

Also, the browser tests fail (re-ran it once, gave same error):

Run npm run install-browser-deps
  
> install-browser-deps
> npm install webdriverio @vitest/browser
npm error Cannot read properties of null (reading 'edgesOut')
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-09-29T21_49_25_024Z-debug-0.log
Error: Process completed with exit code 1.

See: https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/11088816287/job/30825710880?pr=3710

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits/questions

@@ -68,7 +67,7 @@
"@rollup/rollup-linux-x64-gnu": "*"
},
"peerDependencies": {
"@vitest/browser": "2.1.0",
"@vitest/browser": "^2.1.0",
"webdriverio": "^8.39.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the install-browser-deps now installs specific versions of these dependencies, should we then also remove the caret here to ensure this specific version is installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this but when I run the npm run install-browser-deps script, it automatically adds the caret back (no idea why). It should be okay though since we're installing specific versions from the script.

packages/vm/test/api/customChain.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@scorbajio scorbajio merged commit 477dc76 into master Oct 1, 2024
39 checks passed
@scorbajio scorbajio deleted the remove-node-polyfills-shim branch October 1, 2024 16:52
@holgerd77
Copy link
Member

Cool, great! 🙂 🙏

That's really a nice step towards better assured browser compatibility, so that one not always have to doubt if/why these plugins/polyfills are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants