Implement debug_setHead #3811
Implement debug_setHead #3811
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: acolytec3 <[email protected]>
…mjs/ethereumjs-monorepo into debug-setHead-rpc-implementation
| @@ -0,0 +1,96 @@ | |||
| import { Block, createBlock, createBlockHeader } from '@ethereumjs/block' | |||
There was a problem hiding this comment.
I copied these helpers from the blockchain package test helpers in packages/blockchain/test/util.ts. Any thoughts on extracting these out to the util package so that they can be imported for testing and maybe production use cases?
There was a problem hiding this comment.
While looking more into this, I realized this is not possible since it would introduce circular dependencies.
| const oldHead = headHash ? bytesToHex(headHash!) : undefined | ||
| const block = await getBlockByOption(blockOpt, this.chain) | ||
| try { | ||
| await this.service.skeleton?.setHead(block, true) |
There was a problem hiding this comment.
This sets the skeleton head. Should the vm execution part also not be updated? 🤔
There was a problem hiding this comment.
I've updated it to set the execution head as well. 🙂
There was a problem hiding this comment.
Cool, can you also add this check in the tests? :)
There was a problem hiding this comment.
I've updated the tests to include it.
| /** | ||
| * Sets the current head of the local chain by block number. Note, this is a | ||
| * destructive action and may severely damage your chain. Use with extreme | ||
| * caution. |
There was a problem hiding this comment.
This looks like the docs from geth, are these also applicable here?
There was a problem hiding this comment.
Since it is implemented with force=true, I'd say it can be destructive, so it would be good to know in the docs.
| headHash = await this.service.skeleton?.headHash() | ||
| const newHead = headHash ? bytesToHex(headHash!) : undefined | ||
|
|
||
| return `oldHead: ${oldHead} - newHead: ${newHead}` |
There was a problem hiding this comment.
One thought I had here is it would be worth making our response value match Geth's as well. Strings like above are pretty non-standard for RPC responses and you can't parse them programmatically without having to do fancy string parsing.
There was a problem hiding this comment.
Yea, I think you're right will remove. It was a convenient way to develop, but will change it to match.
This change provides an implementation for
debug_setHeadas a part of the work being done in #3781 in order to integrate, develop, and provide an ethereumjs repl console. This work also relates to #1114 and increasing JSON-RPC API coverage.