Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectInfo struct: move out intialOwner and data, add objectRelease #691

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

rapidddenis
Copy link
Collaborator

No description provided.

@rapidddenis
Copy link
Collaborator Author

implements #653

Copy link

gitguardian bot commented Sep 20, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11712615 Triggered Generic High Entropy Secret 45eb988 test/base/GifTest.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Todo Commenter

contracts/instance/InstanceService.sol
TODO:
  • rename exception Line: 348

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis force-pushed the object-version branch 5 times, most recently from 69292cc to 6784e9d Compare October 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant