Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata padding #37

Merged
merged 9 commits into from
Sep 22, 2022
Merged

fix: metadata padding #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
81d8b93
test: fix content-type for .txt file
agazso Aug 27, 2022
d71cb7c
fix: add padding to metadata
agazso Aug 27, 2022
54fe8a3
fix: add metadata size itself to length calculation
agazso Aug 27, 2022
4a84659
test: add test to compare if the hash is same as with Bee
agazso Aug 27, 2022
3cdd3d3
chore: fix prettier issues
agazso Aug 30, 2022
1aeb834
fix: move padding creation to separate function
agazso Sep 2, 2022
ddfe739
fix: bee-factory as dependency
agazso Sep 2, 2022
9e0815a
test: fix tests to run with bee 1.7 and bee-js 5.0
agazso Sep 2, 2022
08f2af5
chore: remove no longer relevant comments
agazso Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,6 @@ jobs:
run: |
echo "${{ secrets.GITHUB_TOKEN }}" | docker login https://docker.pkg.github.com -u ${GITHUB_ACTOR} --password-stdin

# Setup Bee environment
- name: Start Bee Factory environment
run: |
git clone --depth=1 https://github.com/ethersphere/bee-factory.git
chmod +x -R ./bee-factory/scripts
./bee-factory/scripts/environment.sh start --detach --workers=$WORKERS

## Try getting the node modules from cache, if failed npm ci
- uses: actions/cache@v2
id: cache-npm
Expand All @@ -62,6 +55,11 @@ jobs:
- name: Install npm deps
if: steps.cache-npm.outputs.cache-hit != 'true'
run: npm ci

# Setup Bee environment
- name: Start Bee Factory environment
run: npm run bee-factory

- name: Run tests
run: npm run test

Expand Down
10 changes: 4 additions & 6 deletions jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ export default async (): Promise<Config.InitialOptions> => {
console.log('Creating postage stamps...')
const beeDebugUrl = process.env.BEE_DEBUG_API_URL || 'http://localhost:1635'
const bee = new BeeDebug(beeDebugUrl)
process.env.BEE_POSTAGE = await bee.createPostageBatch('1', 20)
process.env.BEE_POSTAGE = await bee.createPostageBatch('1', 20, {
waitForUsable: true,
waitForUsableTimeout: 120_000,
})
console.log('Queen stamp: ', process.env.BEE_POSTAGE)
// sleep for 11 seconds (10 blocks with ganache block time = 1s)
// needed for postage batches to become usable
// FIXME: sleep should be imported for this, but then we fail with
// Could not find a declaration file for module 'tar-js'
await new Promise<void>(resolve => setTimeout(() => resolve(), 11_000))
} catch (e) {
// It is possible that for unit tests the Bee nodes does not run
// so we are only logging errors and not leaving them to propagate
Expand Down
Loading