feat: add screenshot plugin #451

amochuko · 2024-11-19T15:17:59Z

PR to merge screenshot plugin

amochuko · 2024-11-25T14:02:23Z

4.) Cancel an existing flow

I have an unfinished upload from before - whenever I click Swarm Screenshot, it takes me back to where I was in the previous flow. My two options are "Crop" and "Publish to Swarm". I would like to Cancel instead and start anew.

Hello. please I need more clarification of the above:

Because this was my thought process: whenever I have a work flow in progress, and I click Swarm Screenshot, I want my attention to where the flow is. And this also brings the window to focus incase it was behind other applications

Which of these step is best approach:

Do I add a Cancel button to the window to which when clicked will reset the work flow?

Cafe137 · 2024-11-25T14:04:25Z

Hello. please I need more clarification of the above:

It seems that I have written this when I reached an errored out state due to 3.)
Whenever I closed the window and clicked Swarm Screenshot, it got me back to the previous state with no Cancel button.
I think it is working now as intended as long as there are no prior errors.

…(royalty-free camera-shutter)

amochuko · 2024-11-25T15:00:42Z

Hello! Thanks for the PR, it is very nicely put together!

I have some questions and some minor issues I encountered:

1.) License

src/plugins/screenshot/audio/camera_shutter.m4a

src/plugins/screenshot/windows/preview/copy.svg

What are the licensings on these two files? We need to be extra careful to only accept public domain, CC0 assets.

2.) Negative file size

In the preview screen, I see negative values for file sizes, e.g.:

Resolution: 1172 x 886 File Size: -35.86 KB

3.) handleFileUpload errors out with encrypt
[desktop] time="2024-11-25T07:45:55.808Z" level="error" msg="handleFileUpload error: "
[desktop] Error occurred in handler for 'upload-to-swarm': TypeError: Only 32-byte, non-encrypted references are supported
This is caused by trying to convert the Swarm reference to a CID. That whole piece can be removed, we do not really use CIDs. It is OK to only use the Swarm references (a.k.a. Swarm hashes)

4.) Cancel an existing flow

I have an unfinished upload from before - whenever I click Swarm Screenshot, it takes me back to where I was in the previous flow. My two options are "Crop" and "Publish to Swarm". I would like to Cancel instead and start anew.

5.) Take screenshots faster

I think it would be better UX and more seamless if the "Swarm Screenshot" button in the system tray already started the timer without having to click "Take Screenshot" again.

The above observations were fixed in the latest push and as follows:

License:

Replaced copy.svg with in-house design via figma 
Replaced audio with in-house modified audio from pixabay (royalty free)

Fix negative file size
Fix upload error with encrypt option
Initiated capture on window load for seamless UX

src/plugins/screenshot/main.ts

src/plugins/screenshot/windows/capture/capture.html

src/plugins/screenshot/windows/crop/crop.html

ferencsarai · 2024-11-26T10:01:34Z

Hi, great work!
At the bottom of the "screenshot Preview" window, the two buttons are not fully visible on macOS unless I scroll.

…-desktop into screenshot-plugin for new push

amochuko · 2024-11-26T13:32:04Z

Hi, great work! At the bottom of the "screenshot Preview" window, the two buttons are not fully visible on macOS unless I scroll.

Thank you.

In the latest push, I did a fix regarding each observation you made mention.

ferencsarai · 2024-11-26T14:40:58Z

Thank you, great work! If the screenshot preview window could be made taller, that would be fantastic, as the buttons would be fully visible.

amochuko · 2024-11-26T16:02:36Z

Thank you, great work! If the screenshot preview window could be made taller, that would be fantastic, as the buttons would be fully visible.

Thank you too.

I will go fix the height for that.

BTW, just to satisfy curiosity; my display is 13.3 inch Macbook and the height looks perfect.

Here are two snapshots:

This is the default height.

The is the default height + 160 (latest push)

ferencsarai · 2024-11-27T11:18:48Z

Thank you for the screenshots. I use a lower resolution, which is why I encountered the issue. Apologies, the +160 increase is probably unnecessary. The suggested code modifications provide a good view for me at multiple resolutions (Default, More Space).

amochuko · 2024-11-27T11:31:55Z

Thank you for the screenshots. I use a lower resolution, which is why I encountered the issue. Apologies, the +160 increase is probably unnecessary. The suggested code modifications provide a good view for me at multiple resolutions (Default, More Space).

Alright. I appreciate.

Please, just to clarify, should I revert back to initial default or we keep the +160?

ferencsarai · 2024-11-27T12:10:26Z

Please revert to initial default.

amochuko · 2024-11-27T12:27:50Z

Please revert to initial default.

Ok. I've reverted it.

ferencsarai · 2024-11-27T11:15:53Z

src/plugins/screenshot/utils/index.ts

+  const scaleFactor = primaryDisplay.scaleFactor
+
+  const defaultScreenSize = {
+    width: (width / resizeBy) * scaleFactor + 160,


width: Math.floor((width / resizeBy) * scaleFactor), height: Math.floor((height / resizeBy) * scaleFactor),`

`

ferencsarai · 2024-11-27T11:16:56Z

src/plugins/screenshot/windows/preview/preview.css

+img {
+    display: block;
+    max-width: 90%;
+    max-height: 720px;


max-height: 640px;

ferencsarai · 2024-11-27T11:17:54Z

src/plugins/screenshot/windows/preview/preview.ts

+
+  previewWindow = new BrowserWindow({
+    width: defaultScreenSize.width,
+    height: defaultScreenSize.height,


useContentSize: true,

amochuko added 30 commits October 28, 2024 09:18

initial commit for screenshot plugin

78912a0

feat: add screenCaptureWindow

645475e

add interface

90f56ee

add audio

964539a

add getScreenSize util function

d6e5f51

update: add errorHandler to utils

0bd8584

update: made to function name

0570c1b

feat: add screenshot implmenatation

7935910

feat: add screenshot implementation

7ce961b

feat: add screenCaptureWindow

ac1b1ca

add previewWindow

d6454dd

add preview renderer

6193b48

add stylesheet to preview renderer

f8ac0d5

update: add onImageDataURL ipc message

1508e85

update: add previewWindow

7c2d0a2

update: preview captured image on window

d440852

update: add onImageDataURL

0e3f8ed

update: add action buttons

b3c6316

add cropWindow

a4b33d9

update: add window structure

9fadaa8

update: add stylesheet

d876e58

update: add openCropWindow ipc message

e71b4c6

update: add listener for open-crop-window

5182836

update: add cropWindow

604ccec

update: add load-image-for-cropping ipc message

2edf22d

update: add onLoadImageForCropping ipc mesaage

db42a8a

update: add movement logic to selectionBox

0c6e561

update: add updateSelectionBoxHandleRezing

a5f3875

update: add cropImgWithSelectedDimension

81655d0

update: add cropImage ipc messsage

7f97893

update: used in-house modified sound effect from https://pixabay.com/ …

97195e0

…(royalty-free camera-shutter)

amochuko and others added 2 commits November 25, 2024 16:16

update: fix typo

6e13608

Merge branch 'master' into screenshot-plugin

29ab98b

ferencsarai reviewed Nov 26, 2024

View reviewed changes

src/plugins/screenshot/main.ts Show resolved Hide resolved

src/plugins/screenshot/windows/capture/capture.html Outdated Show resolved Hide resolved

src/plugins/screenshot/windows/crop/crop.html Outdated Show resolved Hide resolved

amochuko added 6 commits November 26, 2024 14:00

fix: remove second date object

a436d2e

fix: remove commented-out lines

2e48980

fix: set resizable to false

8b09a6c

update: add style to uploadResultDiv

cfefca9

fix: remove commented-out lines

586501c

Merge branch 'screenshot-plugin' of https://github.com/amochuko/swarm…

6aaaff5

…-desktop into screenshot-plugin for new push

fix: add 160 to defaultScreenSize

d5c2885

fix: revert back to defaultScreenSize

b81767a

ferencsarai approved these changes Nov 27, 2024

View reviewed changes

ferencsarai merged commit d0a3906 into ethersphere:master Nov 28, 2024
1 of 2 checks passed

This was referenced Nov 28, 2024

chore(master): release 0.46.0 #453

Merged

chore(master): release 0.47.0 #454

Merged

amochuko deleted the screenshot-plugin branch November 28, 2024 22:11

bee-worker mentioned this pull request Dec 24, 2024

chore(master): release 0.48.0 #456

Closed

bee-worker mentioned this pull request Jan 15, 2025

chore(master): release 0.41.0 #460

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add screenshot plugin #451

feat: add screenshot plugin #451

amochuko commented Nov 19, 2024 •

edited

Loading

amochuko commented Nov 25, 2024

4.) Cancel an existing flow

Cafe137 commented Nov 25, 2024

amochuko commented Nov 25, 2024 •

edited

Loading

1.) License

2.) Negative file size

3.) handleFileUpload errors out with encrypt

4.) Cancel an existing flow

5.) Take screenshots faster

ferencsarai commented Nov 26, 2024

amochuko commented Nov 26, 2024

ferencsarai commented Nov 26, 2024

amochuko commented Nov 26, 2024 •

edited

Loading

ferencsarai commented Nov 27, 2024

amochuko commented Nov 27, 2024

ferencsarai commented Nov 27, 2024

amochuko commented Nov 27, 2024

ferencsarai Nov 27, 2024

ferencsarai Nov 27, 2024

ferencsarai Nov 27, 2024

feat: add screenshot plugin #451

feat: add screenshot plugin #451

Conversation

amochuko commented Nov 19, 2024 • edited Loading

amochuko commented Nov 25, 2024

4.) Cancel an existing flow

Cafe137 commented Nov 25, 2024

amochuko commented Nov 25, 2024 • edited Loading

1.) License

2.) Negative file size

3.) handleFileUpload errors out with encrypt

4.) Cancel an existing flow

5.) Take screenshots faster

ferencsarai commented Nov 26, 2024

amochuko commented Nov 26, 2024

ferencsarai commented Nov 26, 2024

amochuko commented Nov 26, 2024 • edited Loading

ferencsarai commented Nov 27, 2024

amochuko commented Nov 27, 2024

ferencsarai commented Nov 27, 2024

amochuko commented Nov 27, 2024

ferencsarai Nov 27, 2024

Choose a reason for hiding this comment

ferencsarai Nov 27, 2024

Choose a reason for hiding this comment

ferencsarai Nov 27, 2024

Choose a reason for hiding this comment

amochuko commented Nov 19, 2024 •

edited

Loading

amochuko commented Nov 25, 2024 •

edited

Loading

amochuko commented Nov 26, 2024 •

edited

Loading