Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposed] Update BytecodeObject validation requirements #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Aug 22, 2018

As proposed in #123.

This contains only the formal spec changes. Will need to rewrite the natural language spec if this is change has support.

- Define separate `UnlinkedBytecodeObject` and `LinkedBytecodeObject`
- Use those respectively for `ContractType` and `ContractInstance`
- Ensure unlinked bytecode always requires `link_references`
- Update examples to specify `[]` for bytecode that doesn't link
@gnidan gnidan changed the base branch from master to more-fixes August 22, 2018 00:06
Because the inheritance makes some tools not work right
@gnidan gnidan changed the base branch from more-fixes to master August 22, 2018 20:24
Copy link
Contributor

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! let me know if I can help with updating the docs.

@gnidan
Copy link
Contributor Author

gnidan commented Aug 23, 2018

Thanks @njgheorghita! If you want to take a stab at the docs, be my guest. I won't have time before tomorrow to get to it, unfortunately. Or just feel free to tell me it's my responsibility :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants