Use non-comment type annotation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
njgheorghita
approved these changes
May 5, 2018
|
Python 3.5 support is going to be required for this project as it'll end up as a dependency to web3.py which will support python 3.5 for the foreseeable future. |
|
Oh. That's unfortunate. Good to know. Need to revert this then. Also need
to set up CI to fail on non 3.5 compliant code.
…On Mon, May 7, 2018, 18:13 Piper Merriam ***@***.***> wrote:
Python 3.5 support is going to be required for this project as it'll end
up as a dependency to web3.py which will support python 3.5 for the
foreseeable future.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfzlXxzWzCyaYMpn99vFc2kzhwm67lTks5twHKUgaJpZM4Tzy81>
.
|
|
@cburgdorf made the change back to comment types in #23 |
|
Thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The comment type annotations are only needed for Python 3.5 support which I assume isn't a goal for this project. Comment type annotations have several disadvantages over proper ones.
How was it fixed?
Used proper type annotation.
Cute Animal Picture