Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow matching on extra fields passed to logging calls #25

Open
etianen opened this issue Jan 23, 2024 · 2 comments
Open

Allow matching on extra fields passed to logging calls #25

etianen opened this issue Jan 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@etianen
Copy link
Owner

etianen commented Jan 23, 2024

This would need to be a recursive partial match.
@etianen etianen added the enhancement New feature or request label Jan 23, 2024
@etianen etianen mentioned this issue Jan 27, 2024
Closed
@etianen etianen mentioned this issue Feb 13, 2024
Closed
@will-ockmore will-ockmore mentioned this issue Feb 15, 2024
Merged
@etianen etianen mentioned this issue Feb 25, 2024
Merged
etianen added a commit that referenced this issue Feb 25, 2024
@etianen
Refactor record matching to use internal Matcher class (#126)
98b26f6 
This will make adding new features such as #25, #26 and #80 easier.

It also opens the door to #31 and #124, if desired in future.
@etianen etianen mentioned this issue Feb 25, 2024
Merged
etianen added a commit that referenced this issue Feb 25, 2024
@etianen
Refactored Matcher and Logged to use dataclasses (#127)
71741d8 
This reduces LOC and manual boilerplate for `__eq__` and `__init__`.

This will make adding new features such as #25, #26 and #80 easier.
@mikenerone
Copy link

Just chiming in that this would be extremely helpful. Loggers that support structure (loguru, structlog) encourage contextual data to be put in extra instead of embedded in messages. This is good for analysis and debugging, but makes it (practically) impossible to assert import details with logot currently.

@etianen
Copy link
Owner Author

etianen commented Jun 21, 2024

Nice to hear! I'll have a go at an implementation when I next have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etianen @mikenerone