Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChronosModel and ChronosBoltModel #511

Merged
merged 31 commits into from
Dec 11, 2024
Merged

Add ChronosModel and ChronosBoltModel #511

merged 31 commits into from
Dec 11, 2024

Conversation

egoriyaa
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #509

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Nov 22, 2024

🚀 Deployed on https://deploy-preview-511--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 11:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 11:10 Inactive
@egoriyaa egoriyaa self-assigned this Nov 22, 2024
@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 12:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 12:19 Inactive
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 87.16323% with 81 lines in your changes missing coverage. Please review.

Project coverage is 90.32%. Comparing base (a7e20f4) to head (60e8402).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
etna/libs/chronos/chronos_bolt.py 86.32% 32 Missing ⚠️
etna/libs/chronos/chronos.py 82.75% 30 Missing ⚠️
etna/libs/chronos/base.py 83.67% 8 Missing ⚠️
etna/libs/chronos/utils.py 27.27% 8 Missing ⚠️
etna/settings.py 71.42% 2 Missing ⚠️
etna/models/nn/chronos/base.py 98.92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   90.53%   90.32%   -0.22%     
==========================================
  Files         247      256       +9     
  Lines       16568    17199     +631     
==========================================
+ Hits        15000    15535     +535     
- Misses       1568     1664      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 22, 2024 15:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 1, 2024 22:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 07:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 07:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 07:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 09:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 2, 2024 14:35 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
etna/models/nn/chronos/base.py Outdated Show resolved Hide resolved
During the first initialization model is downloaded from huggingface and saved to local ``cache_dir``.
All following initializations model will be loaded from ``cache_dir``. See ``pretrained_model_name_or_path`` parameter of :py:func:`transformers.PreTrainedModel.from_pretrained`
- If local path, model will not be saved to local ``cache_dir``.
- If external url, it must be zip archive with the same name as model directory inside. Model will be downloaded to ``cache_dir``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we checking it somehow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think real check should be complex like checking ***.safetensor or pytorch_model.bin or config.json is in directory. As the main purpose is developer cases, so we can pay less attention to it.

etna/models/nn/chronos/base.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/test_models/test_nn/test_chronos.py Outdated Show resolved Hide resolved
Copy link

review-notebook-app bot commented Dec 9, 2024

View / edit / reply to this conversation on ReviewNB

d-a-bunin commented on 2024-12-09T08:31:25Z
----------------------------------------------------------------

Line #3.    model_chronos = ChronosModel(path_or_url="amazon/chronos-t5-tiny", encoder_length=2 * HORIZON, num_samples=10)

Do I understand correctly that we set encoder_length to 2*HORIZON only to demonstrate how this value works in the next cell?


egoriyaa commented on 2024-12-09T10:46:43Z
----------------------------------------------------------------

Yes. Also 2*HORIZON was the common value in this notebook.

Copy link
Collaborator Author

egoriyaa commented Dec 9, 2024

Yes. Also 2*HORIZON was the common value in this notebook.


View entire conversation on ReviewNB

@github-actions github-actions bot temporarily deployed to pull request December 9, 2024 11:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 9, 2024 12:11 Inactive
@egoriyaa egoriyaa requested a review from d-a-bunin December 9, 2024 12:36
@github-actions github-actions bot temporarily deployed to pull request December 9, 2024 12:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 10, 2024 07:25 Inactive
@egoriyaa egoriyaa requested a review from d-a-bunin December 10, 2024 07:30
@github-actions github-actions bot temporarily deployed to pull request December 10, 2024 09:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 10, 2024 09:54 Inactive
d-a-bunin
d-a-bunin previously approved these changes Dec 10, 2024
@github-actions github-actions bot temporarily deployed to pull request December 11, 2024 10:02 Inactive
@d-a-bunin d-a-bunin merged commit db5257f into master Dec 11, 2024
17 checks passed
@d-a-bunin d-a-bunin deleted the issue-509 branch December 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ChronosModel and ChronosBoltModel
2 participants