Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework validation of FoldMask to not fail on tail nans #536

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

d-a-bunin
Copy link
Collaborator

@d-a-bunin d-a-bunin commented Dec 18, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

See #531.

Closing issues

Closes #531.

@d-a-bunin d-a-bunin self-assigned this Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

🚀 Deployed on https://deploy-preview-536--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 10:28 Inactive
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (f527fdb) to head (b99b730).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   90.36%   90.35%   -0.01%     
==========================================
  Files         256      256              
  Lines       17303    17299       -4     
==========================================
- Hits        15635    15631       -4     
  Misses       1668     1668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 15:21 Inactive
@d-a-bunin d-a-bunin requested a review from brsnw250 December 19, 2024 07:36
@d-a-bunin d-a-bunin requested a review from brsnw250 December 20, 2024 09:21
@d-a-bunin d-a-bunin merged commit 8c4bdb4 into master Dec 20, 2024
17 checks passed
@d-a-bunin d-a-bunin deleted the issue-531 branch December 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework validation of FoldMask to work with folds full of missing values
2 participants