Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 550 #552

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue 550 #552

wants to merge 4 commits into from

Conversation

brsnw250
Copy link
Collaborator

@brsnw250 brsnw250 commented Dec 31, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Performance graphs (before)

image

image

Proposed Changes

  • Reworked column updates, reducing number of internal copies
  • Added checks for timesatmps and columns (features/segemnts)

Performance graphs (after)

image

image

Code to reproduce

import numpy as np

from etna.datasets import TSDataset, generate_ar_df
from etna.transforms import LagTransform


df = generate_ar_df(n_segments=100000, periods=100, start_time="2000-01-01")
ts = TSDataset(df=df, freq="D")

transform = LagTransform(in_column="target", lags=np.arange(1, 30))
transform.fit_transform(ts=ts)

Closing issues

#550

@brsnw250 brsnw250 self-assigned this Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

🚀 Deployed on https://deploy-preview-552--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 31, 2024 08:42 Inactive
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (438b738) to head (414009d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #552   +/-   ##
=======================================
  Coverage   90.42%   90.43%           
=======================================
  Files         262      262           
  Lines       18234    18242    +8     
=======================================
+ Hits        16488    16497    +9     
+ Misses       1746     1745    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant