Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ODC version CLI parameter to allow version pinning #21

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Add ODC version CLI parameter to allow version pinning #21

merged 3 commits into from
Dec 30, 2023

Conversation

michalszelagsonos
Copy link
Contributor

This PR adds a new CLI option to allow user to specify the version of the ODC so the version does not move on them unexpectedly. This PR addresses #19 which came about when ODC recently jumped to 9.0 and our scans broke since 9.0 is not backwards compatible with 8.x and there was easy way to prevent the new version from being used.

The change allows for local caching of each version so is user specifies v9.0.2 followed by v9.0.4 and then goes back to v9.0.2, both versions will be retained locally and reused if needed.

@michalszelagsonos
Copy link
Contributor Author

@centi can you take a look at this?

@centi centi merged commit 2da79bf into etnetera:main Dec 30, 2023
@michalszelagsonos michalszelagsonos deleted the add-odc-version branch December 31, 2023 13:30
@michalszelagsonos
Copy link
Contributor Author

@centi Will you create a new release and make it available as a npm package here?

@centi
Copy link
Collaborator

centi commented Dec 31, 2023

@michalszelagsonos I will. But I want to look at the other reported issues as well.

@michalszelagsonos
Copy link
Contributor Author

michalszelagsonos commented Jan 19, 2024

@centi Any updates on an upcoming release? I hate to keep pestering, curious on when we can expect one. Even if it is still few weeks out, it would be very helpful to know so we can plan on our end.

FYI, OCD 9.0.8 recently had a regression which broke the scanner again on our end despite it being just a patch update. This feature would have prevented it. Looking forward to having a more stable environment and be able to control the version updates. I appreciate your time and attention on this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants