Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖥️ Improved Window System & Input #1013

Closed
wants to merge 84 commits into from

Conversation

jameskr97
Copy link
Member

@jameskr97 jameskr97 commented Jul 21, 2021

GLFW to replace LowLevelWindow

This PR was originally attempted in #996 though, when I was originally working on it, that branch took several different directions, and I thought too much was happening at once. Those changes will still be coming, but one at a time rather than all at once. This PR is created specifically for the Windowing system replacement, with the organization to only StepMania.{cpp,hpp}.

Changes Include

  • Organizing StepMania.{cpp,h}
  • glew replaced with glad
  • macOS and Linux InputHandler files are being deleted in place of GLFW.
  • Removed src/arch/LowLevelWindow
  • Support for retina displays by using frame-buffer size instead of window size for GL operations. (FrameBuffer typically matches window dimensions on non-retina displays). The top bar is also no longer blurry.

PR to resolve the following issues:

This delays every attempt to build by 2-3 seconds, when after this code is built, it's least likely to change
Accidentally made it's way back in during rebase
It already returns dummy values.
@jameskr97
Copy link
Member Author

Before this pr:
2021-10-24_163002

After this pr:
2021-10-24_163522

The change here is unacceptable, and I will start over.

@jameskr97 jameskr97 closed this Oct 24, 2021
@jameskr97 jameskr97 deleted the feature/glfw branch October 24, 2021 22:57
@poco0317 poco0317 mentioned this pull request Oct 27, 2021
20 tasks
@jameskr97 jameskr97 mentioned this pull request Feb 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant