Adding missing resource string 'euclid_release_version' #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/apps/Settings/res/xml/firmware_version.xml:31: error: resource string/euclid_release_version (aka com.android.settings:string/euclid_release_version) not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
This pull request addresses a build error in firmware_version.xml caused by a missing resource (string/euclid_release_version). The issue prevented the Settings app from building successfully and disrupted the display of firmware information.
Details of the Fix
I added the missing euclid_release_version string resource to resolve this issue. The string now allows the Settings app to compile correctly and ensures that firmware information displays as intended.
Points for Reviewers
The current implementation uses a static string for euclid_release_version. If there’s an intention to make this value dynamic or if it should be sourced differently (e.g., from a build configuration or API), please advise, and I can make further adjustments.
I aimed to align the formatting and naming conventions to maintain consistency with existing resources. Let me know if there are any specific guidelines or preferences that should be taken into account.