Set template context debug=True with "cactus serve" unless "cactus serve --no-debug" #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2014 13:20
To facilitate easily disabling tracking code and the like, imitate Django DEBUG=True and django.core.context_processors.debug. Disable with cactus serve —no-debug.
Explicitly setting host in s3_connect to s3.amazonaws.com interferes with boto using correct host for region, causing Broken Pipe failures when uploading larger files.
| @@ -48,7 +48,7 @@ def _create_connection(self): | |||
| aws_access_key, aws_secret_key = self.credentials_manager.get_credentials() | |||
|
|
|||
| return boto.connect_s3(aws_access_key.strip(), aws_secret_key.strip(), | |||
| host=self._s3_api_endpoint, is_secure=self._s3_is_secure, port=self._s3_port, | |||
There was a problem hiding this comment.
I think the changes in this file have nothing to do with the PR... +1 for the rest of the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate easily disabling tracking code and other "production only" bits, imitate Django DEBUG=True and django.core.context_processors.debug when serving files locally. Disable with cactus serve —no-debug.