-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated packages #60
Updated packages #60
Conversation
Don't know about the dependency change, but please change the commit message. That style is fine for pull requests, but not something that will be remembered until the end of time. Commit message styles has been discussed on Stackoverflow and it references a blog post that gives a sane default. If you didn't know already, here's how to do it: |
I found these resources very helpful:
The best take away was the because clause. Here is my guidelines (rule of thumbs) that I abide by:
|
No problem, I'll take a look and update the commit messages 12 hours later. Thanks for the links. |
Great resources @sukima ! |
This lets travis to test on a newer version on browserify. Additionally the following packages have been updated as well: * esprima to ^2.0.0: switched to jquery foundation's initial supported version * ordered-ast-traverse to "^1.1.1": Changed to get out of 0.x * mocha to ^2.1.0: clearer test reporter
I updated the commit messages. Thanks all. |
Awesome! @maxnordlund what do you think? |
It's very much better, I'm happy as it is right now. What about the actual change? Ping @sukima and @eugeneware |
I don't know of the changes between the change in versions to the dependencies. I don't anticipate any breaking changes. I ran the latest tests on this branch and the four tests pass. My take is the only way to be sure it is all good is to release it to the wild. So I'll merge and it can be reverted if others find problems. |
Good, that seams reasonable. Thanks, @eugeneware can you add @kahwee to the repo as per #53 |
Hey, not sure if you're okay with this. I think running tests on browserify ~v9.0.0 makes more sense since that is the most likely version people would be using in the near future.