Openzeppelin synth fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-03 Missing Docstrings
CR-02 Redeem and Withdraw Might Be Prevented by Enabled Controllers
Signed-off-by: Mick de Graaf <[email protected]>
CR-01 Assets Can be Lost if gulp is Called With Empty Deposit
N-11 Functions Are Updating the State Without Event Emissions
N-09 Incorrect Docstrings
N-08 Gas and Code Improvements
N-06 Non-Explicit Imports Are Used
Signed-off-by: Mick de Graaf <[email protected]>
N-05 Missing Named Parameters in Mapping
N-03 Inconsistent Use of Named Returns
Signed-off-by: Mick de Graaf <[email protected]>
N-01 Function Visibility Overly Permissive
L-02 Incomplete Docstrings
…yz/openzeppelin-synth-fixes-private into openzeppelin-synth-fixes
Comment on lines
+187
to
+188
| _withdraw(_msgSender(), receiver, owner, assets, shares); | ||
| _totalAssets = _totalAssets - assets; |
There was a problem hiding this comment.
Shouldn't _deposit() also be updated to match the pattern here?
There was a problem hiding this comment.
it seems that OZ missed that when reviewing. this was Mick's PR for the issue: https://github.com/euler-xyz/openzeppelin-synth-fixes-private/pull/13/files
There was a problem hiding this comment.
Yeah I noticed that, I guess we either do the full fix or they should mark it as partially fixed in the report.
There was a problem hiding this comment.
fixed here: ca5fca5
This was referenced Jul 5, 2024
hoytech
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.