Fix funnel shift #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funnel shift was using _sym_extract_helper incorrectly. The first bit index must be >= the second bit index. This caused hangs in _sym_extract_helper. Also, according to the docs llvm.fshl extracts the most-significant bits, while llvm.fshr extracts the least-significant. https://llvm.org/docs/LangRef.html#llvm-fshl-intrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funnel shift helpers are using
_sym_extract_helperincorrectly.symcc-rt/src/RuntimeCommon.cpp
Line 440 in 892f817
The first bit index must be >= the second bit index. This caused hangs in _sym_extract_helper.
Also, according to the LLVM docs llvm.fshl should extract the most-significant bits, while llvm.fshr extracts the least-significant.