-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MainMenu, add brightness control #25
Conversation
Somehow it is not yet correctly persisted. I think I am loading globals incorrectly in main.cpp and that makes it reset this to the default value.
Based on #24 , merge this one first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a 15-character limit for keys in Preferences
/ NVS. This most likely causes problems.
Namespace and key names are character strings and are limited to a maximum of 15 characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a potential fix but cannot test it right now.
@TokenRat Please test, confirm its working properly, and merge if you like 👍
Ok, there were more problems. A second Please test yourself and merge afterwards ❤️ |
Improve MainMenu, add brightness control
Somehow it is not yet correctly persisted. I think I am loading globals incorrectly in main.cpp and that makes it reset this to the default value.