Merge branch 'develop'

eusonlito · Nov 21, 2019 · 41a27ca · 41a27ca
2 parents 3b190d2 + e537464
commit 41a27ca
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/Redsys/Tpv/Tpv.php b/src/Redsys/Tpv/Tpv.php
@@ -133,14 +133,27 @@ public function setFormHiddens(array $options)
     }
 
     public function getFormHiddens()
+    {
+        $hiddens = '';
+
+        foreach ($this->getFormValues() as $key => $value) {
+            $hiddens .= $this->getInputHidden($key, $value);
+        }
+
+        return $hiddens;
+    }
+
+    public function getFormValues()
     {
         if (empty($this->values)) {
             throw new Exception('Form fields must be initialized previously');
         }
 
-        return $this->getInputHidden('SignatureVersion', $this->options['SignatureVersion'])
-            .$this->getInputHidden('MerchantParameters', $this->getMerchantParametersEncoded())
-            .$this->getInputHidden('Signature', $this->getValuesSignature());
+        return array(
+            'SignatureVersion' => $this->options['SignatureVersion'],
+            'MerchantParameters' => $this->getMerchantParametersEncoded(),
+            'Signature' => $this->getValuesSignature()
+        );
     }
 
     public function getInputHidden($name, $value)

diff --git a/tests/Redsys/Tpv/TpvTest.php b/tests/Redsys/Tpv/TpvTest.php
@@ -100,6 +100,10 @@ public function testFormFields($tpv)
             'MerchantURL' => 'http://example.com',
         ]);
 
+        $values = $tpv->getFormValues();
+
+        $this->assertTrue(count($values) === count(array_filter($values)));
+
         $fields = $tpv->getFormHiddens();
 
         $this->assertContains('<input', $fields);